Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accept valid unicode identifiers as class parameter to make_class #1406

Merged

Conversation

serge-sans-paille
Copy link
Contributor

Related to #1404

@hynek
Copy link
Member

hynek commented Feb 8, 2025

Thanks! How would you summarize the change for the changelog and .. versionchanged?

attrs.make_class() now allows for Unicode class and field names.

?

@serge-sans-paille
Copy link
Contributor Author

serge-sans-paille commented Feb 8, 2025

It's actually just

attrs.make_class() now allows for Unicode class name

Attribute name was correctly supported before that patch, it's just my testing code that was incorrect (I was testing a kwargs that contained the unnormalized attribute name, and that doesn't work for real class, there's no reason it should work with attrs)

Do you want me to update the patch (if so, where?) or are you going to do the doc/changelog update on your own?

btw thanks for the quick answers!

@hynek
Copy link
Member

hynek commented Feb 9, 2025

thanks; it was faster to do it myself, than explaining it: fc8b9c6

@hynek hynek enabled auto-merge February 9, 2025 07:09
@hynek hynek added this pull request to the merge queue Feb 9, 2025
Merged via the queue into python-attrs:main with commit 75723b7 Feb 9, 2025
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants