WIP: use sphinx_autodoc_typehints #386
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
basnijholt
force-pushed
the
sphinx_autodoc_typehints
branch
2 times, most recently
from
7f26f51
to
f27bf7e
Compare
Codecov Report
@@ Coverage Diff @@
## main #386 +/- ##
==========================================
- Coverage 78.08% 77.84% -0.24%
==========================================
Files 37 37
Lines 5525 5533 +8
Branches 989 991 +2
==========================================
- Hits 4314 4307 -7
- Misses 1064 1070 +6
- Partials 147 156 +9
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
akhmerov
reviewed
Nov 28, 2022
Comment on lines
+36
to
+42
| try: | ||
| from typing import Literal | ||
| except ImportError: | ||
| # Remove this when we drop support for Python 3.7 | ||
| from typing_extensions import Literal | ||
|
|
||
|
|
There was a problem hiding this comment.
I think we can drop 3.7, see https://numpy.org/neps/nep-0029-deprecation_policy.html
We didn't discuss this, but NEP 29 is a good source.
basnijholt
force-pushed
the
sphinx_autodoc_typehints
branch
from
66967c3
to
f7816ba
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of the change and which (if so) issue is fixed.
Fixes #(ISSUE_NUMBER_HERE)
Checklist
pre-commit run --all(first install usingpip install pre-commit)pytestpassedType of change
Check relevant option(s).