feat: Remove cryptocurrency-icons #3137
Merged
+15
−1,096
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
fhqvst
force-pushed
the
fhqvst/ui-275-remove-cryptocurrency-icons
branch
from
1d0a417 to
f711012
Compare
fhqvst
force-pushed
the
fhqvst/ui-275-remove-cryptocurrency-icons
branch
from
f711012 to
02f1720
Compare
benduran
reviewed
Oct 17, 2025
| assetClass={props.feed.product.asset_type} | ||
| symbol={props.feed.symbol} | ||
| /> | ||
| <PriceFeedIcon assetClass={props.feed.product.asset_type} /> |
There was a problem hiding this comment.
nit: I see <PriceFeedIcon assetClass={props.feed.product.asset_type} /> in a lot of places. We could consider keeping things DRY and hoisting this up to a variable, since it seems it's most the same implementation everywhere:
const priceFeedIcon = <PriceFeedIcon assetClass={props.feed.product.asset_type} />
// then, later, down below
icon: priceFeedIconThis way, if we need to change this component for whatever reason, we only need to change it in one place 🙂
cprussin
approved these changes
Oct 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In this PR we remove the
cryptocurrency-iconspackage completely, so to only use the more generic asset-specific icons.Rationale
There have been asks to update some of the currency icons, but it is difficult for us to keep them all up to date, which is why we'd rather use the generic icons instead.
How has this been tested?