Apply suggestions from code review

Co-authored-by: Ran Benita <[email protected]>
pytest-dev · Nov 28, 2024 · 2741b18 · 2741b18
1 parent 5cbe547
commit 2741b18
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/src/_pytest/unraisableexception.py b/src/_pytest/unraisableexception.py
@@ -26,6 +26,7 @@
 
 
 def gc_collect_harder() -> None:
+    # A single collection doesn't necessarily collect everything.
     # Constant determined experimentally by the Trio project.
     for _ in range(5):
         gc.collect()
@@ -114,7 +115,7 @@ def unraisable_hook(
         )
         tracemalloc_tb = tracemalloc_message(unraisable.object)
         msg = summary + traceback_message + tracemalloc_tb
-        cause_msg = summary + tracemalloc_tb
+        cause_msg = summary + "\n" + tracemalloc_tb
 
         append(
             UnraisableMeta(

diff --git a/testing/test_unraisableexception.py b/testing/test_unraisableexception.py
@@ -38,6 +38,7 @@ def test_2(): pass
             "  ",
             "  Traceback (most recent call last):",
             "  ValueError: del is broken",
+            "  ",
             "  Enable tracemalloc to get traceback where the object was allocated.",
             "  See https* for more info.",
             "    warnings.warn(pytest.PytestUnraisableExceptionWarning(msg))",
@@ -76,6 +77,7 @@ def test_2(): pass
             "  ",
             "  Traceback (most recent call last):",
             "  ValueError: del is broken",
+            "  ",
             "  Enable tracemalloc to get traceback where the object was allocated.",
             "  See https* for more info.",
             "    warnings.warn(pytest.PytestUnraisableExceptionWarning(msg))",
@@ -115,6 +117,7 @@ def test_2(): pass
             "  ",
             "  Traceback (most recent call last):",
             "  ValueError: del is broken",
+            "  ",
             "  Enable tracemalloc to get traceback where the object was allocated.",
             "  See https* for more info.",
             "    warnings.warn(pytest.PytestUnraisableExceptionWarning(msg))",