Fix KeyError when replacement worker has mismatched collection
#1299
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a worker crashes and is replaced, if the replacement worker's collection doesn't match the original, add_node_collection() returns early without adding the node to registered_collections. Later, when schedule() calls _reschedule() on all nodes, _assign_work_unit() crashes with KeyError accessing registered_collections[node]. Add a guard in _reschedule() to skip nodes that aren't in registered_collections. Fixes pytest-dev#1189 Fixes pytest-dev#714
bendrucker
force-pushed
the
fix-replacement-worker-keyerror
branch
from
9a9e365 to
78bec67
Compare
bendrucker
changed the title
KeyError when replacement worker has mismatched collection
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a
KeyErrorcrash when a replacement worker's test collection doesn't match the original. This can occur when using--dist=loadgroupand a worker crashes, then the replacement worker sees different tests (e.g., due to a race condition or test file changes during the run).Changes
_reschedule()to skip nodes that aren't inregistered_collectionsRoot Cause
When a worker crashes and is replaced:
add_node_collection()registered_collectionsassigned_workviaadd_node()schedule()iterates overself.nodes(fromassigned_work.keys()) and calls_reschedule()on each_reschedule()calls_assign_work_unit()which crashes withKeyErrorThe fix adds a simple guard to skip nodes that aren't properly registered.
Related