Test and restore compatibility with older PySide/PyQt versions#597
Merged
The-Compiler merged 6 commits intomasterfrom Mar 25, 2025
Merged
Test and restore compatibility with older PySide/PyQt versions#597The-Compiler merged 6 commits intomasterfrom
The-Compiler merged 6 commits intomasterfrom
Conversation
qInfo() has been added: https://codereview.qt-project.org/c/pyside/pyside-setup/+/605100 Follow-up / alternative to #593 without breaking compatibility with older PySide6 versions. See #232.
Follow-up to #525 to conditionally do the right thing based on the PySide6 version, so we can continue to run tests with older versions.
We support older versions of PySide6/PyQt6, so we should also test with the oldest versions we support to prevent regressions.
Since we run pytester in-process, the patching of qt_api.get_versions will leak into the rest of the testsuite (even if done in a temporary conftest.py, the qt_api module is the same!). This causes Qt API version checks in the testsuite to be broken.
nicoddemus
approved these changes
Mar 25, 2025
Member
nicoddemus
left a comment
nicoddemus
left a comment
There was a problem hiding this comment.
Thanks, appreciate the individual commits.
I fumbled on #593, thanks for fixing it!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR:
qInfois present or not)qInfo(and not ourQMessageLoggershim) if presentqt_compat.py) to avoid future regressionsProbably best reviewed commit by commit (and not squash-merged).