Fix pre-commit errors #80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A long line in this docstring was causing the flake8 pre-commit check to fail, so I edited the comment to be compliant. I shortened the lines to about 80 characters for consistency with other comments, even though that's more of a change than is strictly required to pass flake8. With this change, we can start requiring pre-commit to pass for all merges. I also changed a note to use Restructured Text syntax, for compatibility with other docstrings in the project.
The actionlint hook uses Docker, which isn't configured in the runners used by pre-commit.ci, so I'm marking that one to be skipped. In the future we can set up some alternate way of running actionlint on pull requests automatically.
diazona
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A long line in this docstring was causing the flake8 pre-commit check to fail, so I edited the comment to be compliant. I shortened the lines to about 80 characters for consistency with other comments, even though that's more of a change than is strictly required to pass flake8. With this change, we can start requiring pre-commit to pass for all merges.
I also changed a note to use Restructured Text syntax, for compatibility with other docstrings in the project.
I also changed the pre-commit configuration to skip the actionlint hook, because it's not configured to run Docker hooks.