Escape HTML in the test id column#1036
Open
golikovichev wants to merge 1 commit into
Open
Conversation
The parametrized test id (report.nodeid) was interpolated into the results table cell without escaping, so a test parameter containing HTML rendered as live markup in the report. Escape it the same way the log cell already is. Closes pytest-dev#1024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The parametrized test id (report.nodeid) is interpolated into the results table cell in basereport.py without escaping:
When a test parameter contains HTML, the value reaches the report data verbatim and the renderer inserts it with innerHTML, so it shows as live markup instead of text. Reproduction from #1024 is a parametrized value such as a span tag with inline style.
Fix: escape the test id, the same way the log cell already is (escape on report.longreprtext). One line.
Test: added test_html_in_test_id_is_escaped in testing/test_unit.py. It runs a session with an HTML test id, reads the report data blob, and asserts the test id cell contains the escaped form rather than the raw tags.
Closes #1024