-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Custom error message for comparison-with-callable #1130
Conversation
Pull Request Test Coverage Report for Build 12736593179Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @herenali! I left some comments for the specific message, but otherwise looks good.
@@ -13,6 +13,7 @@ W0199 = "Calling assert on a tuple will only evaluate to False if it is empty. I | |||
|
|||
["pylint.checkers.base".ComparisonChecker] | |||
C0123 = "You should use 'isinstance(x, my_type)' instead of 'type(x) == my_type' to check the type of a value." | |||
W0143 = "This expression includes a comparison against a callable. It's likely you meant to call a function but omitted the parenthesis." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's use just the term "function" instead of "callable" in the description, as the latter isn't commonly taught for beginners.
And at the end, please say "parenthesis, ()" instead of just "parenthesis", just to be a bit more concrete.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @herenali!
Proposed Changes
Added custom error message for comparison-with-callable (W0143) to improve clarity of error message.
...
Type of Change
(Write an
X
or a brief description next to the type or types that best describe your changes.)Checklist
(Complete each of the following items for your pull request. Indicate that you have completed an item by changing the
[ ]
into a[x]
in the raw text, or by clicking on the checkbox in the rendered description on GitHub.)Before opening your pull request:
After opening your pull request:
Questions and Comments
(Include any questions or comments you have regarding your changes.)