-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Z3 depdendency check ci #1126
Z3 depdendency check ci #1126
Conversation
Configue CI matrix with "base" and "z3-solver". z3 is installed only for z3-solver config
Add --exclude-z3 flag to pytest to skip tests the require z3 dependency Configure --exclude-z3 in CI test
Fix regex for matching z3-related modules Exclude z3 tests in test_examples
Pull Request Test Coverage Report for Build 12623091081Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
.github/workflows/test.yml
Outdated
pip install -e .[dev,cfg,z3] | ||
pip install -e .[dev,cfg] | ||
if [ "${{ matrix.dependency }}" == "z3-solver" ]; then | ||
pip install z3-solver |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use .[z3]
instead of z3-solver
(this will ensure we're installing everything in the "z3" group, which may be added to in the future)
CHANGELOG.md
Outdated
@@ -18,6 +18,8 @@ and adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html). | |||
|
|||
### 🔧 Internal changes | |||
|
|||
- Configued CI tests to run on environments with and without `z3` dependency. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typo in "Configued"
Proposed Changes
(Describe your changes here. Also describe the motivation for your changes: what problem do they solve, or how do they improve the application or codebase? If this pull request fixes an open issue, use a keyword to link this pull request to the issue.)
Configure CI tests to run on
base
(z3-solver
uninstalled) andz3-solver
(z3-solver
installed).Add
--exclude-z3
Pytest command-line argument to exclude test suites dependeing onz3-solver
...
Screenshots of your changes (if applicable)
Type of Change
(Write an
X
or a brief description next to the type or types that best describe your changes.)Checklist
(Complete each of the following items for your pull request. Indicate that you have completed an item by changing the
[ ]
into a[x]
in the raw text, or by clicking on the checkbox in the rendered description on GitHub.)Before opening your pull request:
After opening your pull request:
Questions and Comments
(Include any questions or comments you have regarding your changes.)