Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New import convention for TopoNetX #361

Merged
merged 1 commit into from
Jun 3, 2024
Merged

Conversation

ffl096
Copy link
Member

@ffl096 ffl096 commented May 31, 2024

Closes #335.

@ffl096 ffl096 added the enhancement New feature or request label May 31, 2024
@ffl096 ffl096 self-assigned this May 31, 2024
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@ffl096 ffl096 force-pushed the frantzen/import-convention branch from 8dfe661 to 365759d Compare May 31, 2024 15:30
Copy link

codecov bot commented May 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.38%. Comparing base (e058e0d) to head (3a49c7c).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #361      +/-   ##
==========================================
+ Coverage   97.37%   97.38%   +0.01%     
==========================================
  Files          37       38       +1     
  Lines        3547     3562      +15     
==========================================
+ Hits         3454     3469      +15     
  Misses         93       93              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ffl096 ffl096 force-pushed the frantzen/import-convention branch from 365759d to 3a49c7c Compare May 31, 2024 15:35
@mhajij mhajij self-requested a review June 3, 2024 07:33
Copy link
Member

@mhajij mhajij left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

really important improvement

@mhajij mhajij merged commit bde7390 into main Jun 3, 2024
9 checks passed
@mhajij mhajij deleted the frantzen/import-convention branch June 3, 2024 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Import Convention for TopoNetX
2 participants