Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor SimplicialComplex.add_simplex function #359

Merged
merged 1 commit into from
May 29, 2024

Conversation

ffl096
Copy link
Member

@ffl096 ffl096 commented May 29, 2024

This pull request makes the implementation of SimplicialComplex.add_simplex a bit simpler and allows to introduce changes more easily in the future.
Along the way, an inconsistency when providing a Simplex class with attributes and additional kwargs in different cases was fixed.

@ffl096 ffl096 self-assigned this May 29, 2024
Copy link

codecov bot commented May 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.37%. Comparing base (fc47106) to head (13ac77e).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #359   +/-   ##
=======================================
  Coverage   97.37%   97.37%           
=======================================
  Files          37       37           
  Lines        3543     3543           
=======================================
  Hits         3450     3450           
  Misses         93       93           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ffl096 ffl096 force-pushed the frantzen/refactor-add-simplex-function branch from 919c831 to 13ac77e Compare May 29, 2024 14:48
@ffl096 ffl096 merged commit be497a1 into main May 29, 2024
9 checks passed
@ffl096 ffl096 deleted the frantzen/refactor-add-simplex-function branch May 29, 2024 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant