adding hasse graph #331
Merged
adding hasse graph #331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #331 +/- ##
==========================================
- Coverage 96.87% 96.86% -0.01%
==========================================
Files 32 32
Lines 3518 3544 +26
==========================================
+ Hits 3408 3433 +25
- Misses 110 111 +1 ☔ View full report in Codecov by Sentry. |
ffl096
reviewed
Dec 24, 2023
toponetx/classes/cell_complex.py
Outdated
Comment on lines
2430
to
2442
| G.add_node(str(tuple((n,)))) | ||
| for e in self.edges: | ||
| (u,v) = sorted(e) | ||
|
|
||
| G.add_node( str((u,v)) ) | ||
| G.add_edge(str(tuple((u,))),str((u,v))) | ||
| G.add_edge(str(tuple((v,))),str((u,v))) | ||
| for c in self.cells: | ||
| G.add_node( str(c.elements) ) | ||
| for e in list(c.boundary): | ||
| (u,v) = sorted(e) | ||
| G.add_edge(str( (u,v) ),str(c.elements)) | ||
| G.add_edge(str( (u,v) ),str(c.elements)) |
There was a problem hiding this comment.
Is there a reason why you add the tuples as strings? NetworkX is perfectly happy with tuple identifiers:
G = nx.Graph()
G.add_node((1, 2))
G.add_edge((1, 2), (4, 5))
G.number_of_nodes() # == 2
G.number_of_edges() # == 1
ffl096
approved these changes
Jan 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adding Hasse graph to CC and SC.