Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing solution for issue #195 #239

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

devendragovil
Copy link
Contributor

Trying a way to resolve the datasets issue #195. Will need to raise a PR for this to test out the solution

… raise a PR for this to test out the solution
@devendragovil devendragovil marked this pull request as draft September 12, 2023 09:02
@codecov
Copy link

codecov bot commented Sep 12, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.69% 🎉

Comparison is base (5570330) 85.56% compared to head (2b00eb1) 86.25%.
Report is 27 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #239      +/-   ##
==========================================
+ Coverage   85.56%   86.25%   +0.69%     
==========================================
  Files          23       23              
  Lines        2848     3377     +529     
==========================================
+ Hits         2437     2913     +476     
- Misses        411      464      +53     

see 9 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ffl096
Copy link
Member

ffl096 commented Sep 13, 2023

I am not experienced with setuptools and thus cannot comment on the right approach here. Removing me as reviewer here :)

@ffl096 ffl096 removed their request for review September 13, 2023 06:09
@devendragovil
Copy link
Contributor Author

@mhajij This PR is not ready yet.

I initially raised this PR so as to be able to test my solutions. Converting this to draft for now.

@devendragovil devendragovil marked this pull request as draft September 13, 2023 19:32
@mhajij mhajij requested a review from ffl096 September 14, 2023 02:05
@mhajij mhajij closed this Sep 21, 2023
@ffl096
Copy link
Member

ffl096 commented Sep 22, 2023

@mhajij did you mean to close this?

@mhajij mhajij reopened this Sep 22, 2023
@mhajij
Copy link
Member

mhajij commented Sep 22, 2023

@mhajij did you mean to close this?

@ffl096, I reopened it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants