Skip to content

Commit

Permalink
docs: added maintainer advice section (#506)
Browse files Browse the repository at this point in the history
* docs: added maintainer advice section

* remove myself from readme head
  • Loading branch information
port19x authored Feb 7, 2022
1 parent a38c857 commit a9fec7f
Show file tree
Hide file tree
Showing 2 changed files with 13 additions and 1 deletion.
13 changes: 13 additions & 0 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,19 @@
9. Use [shellcheck](https://github.com/koalaman/shellcheck) before pushing (recommended)
10. Test using the dash shell, since it's strictly posix compliant

## Advice for maintainers

1. Always use [semantic commits](https://gist.github.com/joshbuchea/6f47e86d2510bce28f8e7f42ae84c716) when merging to master
2. Remove features. Who will do it if you don't?
3. Use labels
4. Link PRs to the issues they solve
5. Assign issues if you know who will/should solve them
6. Close stale, unreproducible and low quality issues
7. Don't use projects or milestones, they don't add any value to the workflow
8. Don't advertise to the wrong demographic
9. Don't advertise
10. Help new contributors find things to work on

## Testing

Our parsing was broken in the past and it will break in the future
Expand Down
1 change: 0 additions & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@
<br>
<a href="https://discord.gg/aqu7GpqVmR"><img src="https://invidget.switchblade.xyz/aqu7GpqVmR"></a>
<br>
<a href="https://github.com/ura43"><img src="https://img.shields.io/badge/lead-ura43-lightblue"></a>
<a href="https://github.com/CoolnsX"><img src="https://img.shields.io/badge/maintainer-CoolnsX-blue"></a>
<a href="https://github.com/RaynardGerraldo"><img src="https://img.shields.io/badge/maintainer-RayGL-blue"></a>
<br>
Expand Down

0 comments on commit a9fec7f

Please sign in to comment.