Fix BUG #1105 - "Spyder fails with HEAD" #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Checking if a type is an Object Type is a very common task, followed by asking if a type is a pointer to a type that has a Python wrapper. These functions solve the problem: ShibokenGenerator::isObjectType(type) ShibokenGenerator::isPointerToWrapperType(type) I refactored the generator code to make use of those functions. Reviewed by Hugo Parente <[email protected]> Reviewed by Lauro Moura <[email protected]> Reviewed by Luciano Wolf <[email protected]>
ShibokenGenerator::isPointer() ShibokenGenerator::isWrapperType() Reviewed by Hugo Parente <[email protected]> Reviewed by Luciano Wolf <[email protected]>
…e to QML (qmlRegisterType) function. Reviewer: Luciano Wolf <[email protected]> Lauro Moura <[email protected]>
Reviewed by Hugo Parente <[email protected]> Reviewed by Luciano Wolf <[email protected]>
…odule succeeds" Reviewer: Luciano Wolf <[email protected]> Marcelo Lira <[email protected]>
Reviewer: Luciano Wolf <[email protected]> Lauro Neto <[email protected]>
manager exit. Reviewer: Hugo Parente <[email protected]> Luciano Wolf <[email protected]>
…signatures" Reviewer: Renato Araújo <[email protected]> Luciano Wolf <[email protected]>
The new methods replace the contents of the following type system variables: %CONVERTTOPYTHON %CONVERTTOCPP %ISCONVERTIBLE %CHECKTYPE The replacements were part of the ShibokenGenerator::writeCodeSnips() method.
…or to Generator Runner. They were needed by other methods in the Generator class.
…or Runner. Updated tests' type systems to reflect the behaviour of Generator::minimalConstructor().
The Shiboken::Module namespace also provides management of module types, including the communication of types among dependent modules. Module::create() will call Shiboken::init(), so this can be removed from the generated module's source code. This deprecates the old Shiboken::importModule() function. The generation of module initialization code was updated to use the new Shiboken::Module functions.
…ule or enclosing class. The class register writer was updated to use the new ObjectType::introduceWrapperType(). Types are now created and registered via the introduceWrapperType() function. I also did a little refactoring on CppGenerator::writeClassRegister.
Also removed the default value for a more explicit use of the method.
Now anyone wanting to get a cppSelf object must go through this method.
The indentation, and everything else about it, was terrible.
…ToCppTypeConversion().
Added test for a reference to integer as a function argument.
…ode. The contents of the new CppGenerator::writeMethodWrapperPreamble() method were moved from the writers of constructor and method wrappers. Reviewed by Hugo Parente <[email protected]> Reviewed by Luciano Wolf <[email protected]>
…d on a given string. Also added code to register a couple of type conversions by name, a bunch of related tests, and some fixes to the converter functions.
Also removed erroneus deletions of said AbstractMetaTypes - they are kept in a cache and should be deleted only when the generator is finished.
Reviewer: Marcelo Lira <[email protected]>
…f long. Using long causes erratic behaviour on linux in 64-bits architectures. Sometimes.
E.g., when calling QtGui.QShortcut.setKey(QtCore.Qt.CTRL + QtCore.Qt.Key_Delete) it was being called as QtGui.QShortcut.setKey(long) (in Python 2) when it should be actually QtGui.QShortcut.setKey(int). So that resulted in a TypeError exception when using Python version 2 with that small code. See http://bugs.pyside.org/show_bug.cgi?id=1097. Signed-off-by: Paulo Alcantara <[email protected]> Reviewed-by: Marcelo Lira <[email protected]> Reviewed-by: Hugo Parente Lima <[email protected]>
Expanded the Complex type conversion unit test. Reviewed by Hugo Parente <[email protected]> Reviewed by Paulo Alcantara <[email protected]>
See http://bugs.pyside.org/show_bug.cgi?id=1092. Signed-off-by: Paulo Alcantara <[email protected]> Reviewed-by: Marcelo Lira <[email protected]> Reviewed-by: Hugo Parente Lima <[email protected]>
Reviewed by Lauro Moura <[email protected]> Reviewed by Luciano Wolf <[email protected]>
When handling typedef'd primitive types we don't need to create indices for them, nor converters. Instead, we must use the underlying primitive type converters. See http://bugs.pyside.org/show_bug.cgi?id=1105. Signed-off-by: Paulo Alcantara <[email protected]>
|
+1 |
1 similar comment
|
+1 |
|
Marcelo Lira seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When handling typedef'd primitive types we don't need to create indices
for them, nor converters. Instead, we must use the underlying primitive
type converters.
See http://bugs.pyside.org/show_bug.cgi?id=1105.
Signed-off-by: Paulo Alcantara [email protected]