RC 0.2.1 #46

jklenzing · 2024-10-04T17:32:21Z

Description

Release candidate. Updates compliance with pysat 3.2.x for unit tests, standards for community documents and actions.

Type of change

Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

via GitHub Actions

Test Configuration:

Operating system: Windows, ubuntu, mac
Version number: Python 3.10, 3.11, 3.12

Checklist:

If this is a release PR, replace the first item of the above checklist with the
release checklist on the pysat wiki:
https://github.com/pysat/pysat/wiki/Checklist-for-Release

Release changes back to develop

MAINT: pytest syntax, GA versions

TST: add workflow_dispatch for pysat RC

Co-authored-by: Angeline Burrell <[email protected]>

MAINT: use coveralls app

Co-authored-by: Angeline Burrell <[email protected]>

MAINT: update standard docs

Updated acknowledgements to include ONR.

Added acknowledgement to docs.

Update the code comments to include the pub release block.

NRL pub release

.github/ISSUE_TEMPLATE/bug_report.md

.readthedocs.yml

pyproject.toml

Co-authored-by: Angeline Burrell <[email protected]>

aburrell · 2024-11-07T19:05:23Z

CHANGELOG.md

@@ -2,6 +2,18 @@
 All notable changes to this project will be documented in this file.
 This project adheres to [Semantic Versioning](http://semver.org/).

+## [0.2.1] - 2024-11-01


Need to update release date.

jklenzing · 2024-11-13T20:41:07Z

CHANGELOG.md

@@ -2,6 +2,18 @@
 All notable changes to this project will be documented in this file.
 This project adheres to [Semantic Versioning](http://semver.org/).

+## [0.2.1] - 2024-11-01


Suggested change

## [0.2.1] - 2024-11-01

## [0.2.1] - 2024-11-15

rstoneback

Thanks for working to get this package up to speed and out of the proverbial dark ages.

rstoneback · 2024-11-14T20:46:05Z

.github/workflows/main.yml

-           - python-version: "3.8"
-             numpy_ver: "1.21"
+           # NEP29 compliance settings
+           - python-version: "3.10"


I think we should maintain the same operational testing Python version for the pysatPenumbra packages as pysat does.

Hard disagree. Core pysat has different needs then the penumbra packages and should not dictate what each package in the ecosystem decides to do.

Historically, this package has never supported the operational env. I have limited time. If you would like to lead a pull for a future version, you are welcome to do so.

rstoneback · 2024-11-14T20:53:11Z

docs/conf.py

+# Full license can be found in License.md
+# DOI:10.5281/zenodo.3475493
+#
+# DISTRIBUTION STATEMENT A: Approved for public release. Distribution is


I'd prefer if we used the updated distribution statement thing going forward.

Suggested change

# DISTRIBUTION STATEMENT A: Approved for public release. Distribution is

# Review Status for Classified or Controlled Information by NRL

# -------------------------------------------------------------

# DISTRIBUTION STATEMENT A: Approved for public release. Distribution is

This can be an issue for the future.

rstoneback · 2024-11-14T20:54:15Z

docs/index.rst

+   acknowledgements.rst
+
+
+.. admonition:: DISTRIBUTION STATEMENT A: Approved for public release.


Same here.

Suggested change

.. admonition:: DISTRIBUTION STATEMENT A: Approved for public release.

.. admonition:: Review Status for Classified or Controlled Information by NRL

-------------------------------------------------------------

DISTRIBUTION STATEMENT A: Approved for public release.

The formatting lines up in the editing window. Not so much after it gets posted... :(

rstoneback · 2024-11-14T20:56:18Z

pyproject.toml

+version = "0.2.1"
+description = "Seasonal analysis routines for pysat"
+readme = "README.md"
+requires-python = ">=3.10"


Same comment about minimum python version. I think the penumbra packages should maintain consistency with the pysat release requirements.

rstoneback · 2024-11-14T20:57:00Z

pysatSeasons/__init__.py

@@ -2,6 +2,10 @@
 # -*- coding: utf-8 -*-
 # Copyright (C) 2022, pysat development team
 # Full license can be found in License.md
+# DOI:10.5281/zenodo.3475493
+#
+# DISTRIBUTION STATEMENT A: Approved for public release. Distribution is


Suggested change

# DISTRIBUTION STATEMENT A: Approved for public release. Distribution is

# Review Status for Classified or Controlled Information by NRL

# -------------------------------------------------------------

# DISTRIBUTION STATEMENT A: Approved for public release. Distribution is

rstoneback · 2024-11-14T20:58:17Z

pysatSeasons/tests/test_avg.py

@@ -2,6 +2,10 @@
 # -*- coding: utf-8 -*-
 # Copyright (C) 2022, pysat development team
 # Full license can be found in License.md
+# DOI:10.5281/zenodo.3475493
+#
+# DISTRIBUTION STATEMENT A: Approved for public release. Distribution is


Suggested change

# DISTRIBUTION STATEMENT A: Approved for public release. Distribution is

# Review Status for Classified or Controlled Information by NRL

# -------------------------------------------------------------

# DISTRIBUTION STATEMENT A: Approved for public release. Distribution is

rstoneback · 2024-11-14T20:59:08Z

pysatSeasons/tests/test_avg.py

        self.bounds1 = (dt.datetime(2008, 1, 1), dt.datetime(2008, 1, 3))
        self.bounds2 = (dt.datetime(2009, 1, 1), dt.datetime(2009, 1, 2))

        return


-class TestFrameProfileAverages(object):


I think the currently listed minimum supported pysat version still has these alternate formats....
I've forgotten exactly when those were removed though.

rstoneback · 2024-11-14T21:01:16Z

pysatSeasons/tests/test_core.py

@@ -2,6 +2,10 @@
 # -*- coding: utf-8 -*-
 # Copyright (C) 2022, pysat development team
 # Full license can be found in License.md
+# DOI:10.5281/zenodo.3475493
+#
+# DISTRIBUTION STATEMENT A: Approved for public release. Distribution is


Suggested change

# DISTRIBUTION STATEMENT A: Approved for public release. Distribution is

# Review Status for Classified or Controlled Information by NRL

# -------------------------------------------------------------

# DISTRIBUTION STATEMENT A: Approved for public release. Distribution is

rstoneback · 2024-11-14T21:01:26Z

pysatSeasons/tests/test_occur_prob.py

@@ -2,6 +2,10 @@
 # -*- coding: utf-8 -*-
 # Copyright (C) 2022, pysat development team
 # Full license can be found in License.md
+# DOI:10.5281/zenodo.3475493
+#
+# DISTRIBUTION STATEMENT A: Approved for public release. Distribution is


Suggested change

# DISTRIBUTION STATEMENT A: Approved for public release. Distribution is

# Review Status for Classified or Controlled Information by NRL

# -------------------------------------------------------------

# DISTRIBUTION STATEMENT A: Approved for public release. Distribution is

rstoneback · 2024-11-14T21:01:38Z

pysatSeasons/tests/test_plot.py

@@ -2,6 +2,10 @@
 # -*- coding: utf-8 -*-
 # Copyright (C) 2022, pysat development team
 # Full license can be found in License.md
+# DOI:10.5281/zenodo.3475493
+#
+# DISTRIBUTION STATEMENT A: Approved for public release. Distribution is


Suggested change

# DISTRIBUTION STATEMENT A: Approved for public release. Distribution is

# Review Status for Classified or Controlled Information by NRL

# -------------------------------------------------------------

# DISTRIBUTION STATEMENT A: Approved for public release. Distribution is

rstoneback and others added 30 commits October 28, 2022 11:21

Merge pull request #34 from pysat/rcv0-2-0

8c44ebf

Release changes back to develop

STY: pytest syntax

0e76ead

DOC: update changelog

185a56f

MAINT: update github actions

db7089f

DOC: update changelog

8d42f86

TST: add workflow for pysat rc

e25819d

TST: set test to manual

2f940cc

DOC: update changelog

34ae736

Merge pull request #35 from pysat/tst/syntax

12dae08

MAINT: pytest syntax, GA versions

Merge branch 'develop' into tst/rc

f4b5d2b

Merge pull request #36 from pysat/tst/rc

f256ea9

TST: add workflow_dispatch for pysat RC

TST: add RC install workflow

3a4dc7c

STY: update pip install for RC workflow

b39df79

STY: set workflows to push

982c916

DOC: update changelog

738d3e7

MAINT: add hacking cap

37f5426

TST: set workflows to dispatch

ba5eaad

Apply suggestions from code review

ac9333d

Merge pull request #38 from pysat/tst/ga_updates

59503ce

MAINT: remove tests no longer suported by pysat

438be78

BUG: fix workflow dispatch

f9bc3f5

DOC: update changelog

dd67193

MAINT: replace testing_xarray

ea9e856

MAINT: update workflows

bc54e41

MAINT: use ndtesting

93f75dd

BUG: use correct samples

1423263

MAINT: set to workflow dispatch

d978b39

Update .github/workflows/docs.yml

d14d860

Co-authored-by: Angeline Burrell <[email protected]>

Update .github/workflows/main.yml

f7f4fdd

MAINT: NEP29

3edb558

jklenzing and others added 15 commits August 13, 2024 13:58

Update CHANGELOG.md

eefd02c

Merge pull request #43 from pysat/maint/coveralls

79d87d0

MAINT: use coveralls app

MAINT: update issues

77b7446

MAINT: update workflows

c44b333

MAINT: update contributing

4bd5eec

MAINT: update license date

413e1f9

DOC: update changelog

1104cb1

MAINT: add acknowledgements

2c10520

Update CHANGELOG.md

ad35da8

Co-authored-by: Angeline Burrell <[email protected]>

Merge pull request #44 from pysat/maint/37_docs

1420916

MAINT: update standard docs

DOC: updated acknowledgements

642b40b

Updated acknowledgements to include ONR.

DOC: updated docs

39eb30a

Added acknowledgement to docs.

DOC: update code statement block

df0670f

Update the code comments to include the pub release block.

Merge pull request #45 from pysat/nrl_pub_release

5f72686

NRL pub release

MAINT: update rc stuff

4d8d937

jklenzing added this to the 0.2.1 Release milestone Oct 4, 2024

jklenzing added 2 commits October 9, 2024 17:07

MAIMT: add readthedocs yml

827fa9a

Merge branch 'main' into rc0_2_1

a905807

jklenzing marked this pull request as ready for review October 15, 2024 14:49

jklenzing requested review from rstoneback, aburrell and JonathonMSmith October 15, 2024 14:51

aburrell reviewed Oct 21, 2024

View reviewed changes

.github/ISSUE_TEMPLATE/bug_report.md Outdated Show resolved Hide resolved

.readthedocs.yml Outdated Show resolved Hide resolved

pyproject.toml Outdated Show resolved Hide resolved

Apply suggestions from code review

5145c24

Co-authored-by: Angeline Burrell <[email protected]>

jklenzing requested a review from aburrell November 7, 2024 19:00

aburrell reviewed Nov 7, 2024

View reviewed changes

jklenzing commented Nov 13, 2024

View reviewed changes

aburrell approved these changes Nov 13, 2024

View reviewed changes

rstoneback reviewed Nov 14, 2024

View reviewed changes

jklenzing requested a review from rstoneback November 15, 2024 15:09

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

RC 0.2.1 #46

RC 0.2.1 #46

jklenzing commented Oct 4, 2024 •

edited

Loading

aburrell Nov 7, 2024

jklenzing Nov 13, 2024

rstoneback left a comment

rstoneback Nov 14, 2024

aburrell Nov 14, 2024

jklenzing Nov 15, 2024

rstoneback Nov 14, 2024

aburrell Nov 14, 2024

rstoneback Nov 14, 2024

rstoneback Nov 14, 2024

rstoneback Nov 14, 2024

rstoneback Nov 14, 2024

rstoneback Nov 14, 2024

rstoneback Nov 14, 2024

rstoneback Nov 14, 2024

rstoneback Nov 14, 2024

		acknowledgements.rst


		.. admonition:: DISTRIBUTION STATEMENT A: Approved for public release.

RC 0.2.1 #46

Are you sure you want to change the base?

RC 0.2.1 #46

Conversation

jklenzing commented Oct 4, 2024 • edited Loading

Description

Type of change

How Has This Been Tested?

Checklist:

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rstoneback left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jklenzing commented Oct 4, 2024 •

edited

Loading