Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kubernetes: Update SLO resource's status #801

Merged
merged 1 commit into from
Jul 21, 2023
Merged

Conversation

metalmatze
Copy link
Member

So far running kubectl get slo would only show something similar to this:

NAMESPACE    NAME                                                      AGE
monitoring   servicelevelobjective.pyrra.dev/pyrra-filesystem-errors   18h
monitoring   servicelevelobjective.pyrra.dev/thanos-query              18h

With these changes the status contains the resource type that was generated. Either PrometheusRule or ConfigMap. Additionally, some fields from the spec are extracted and shown in the output too:

kubectl get slo,prometheusrule

NAMESPACE    NAME                                                      WINDOW   TARGET   TYPE            AGE
monitoring   servicelevelobjective.pyrra.dev/pyrra-filesystem-errors   1w       99       PrometheusRule  18h
monitoring   servicelevelobjective.pyrra.dev/thanos-query              4w       99       PrometheusRule  18h

NAMESPACE    NAME                                                           AGE
monitoring   prometheusrule.monitoring.coreos.com/pyrra-filesystem-errors   18h
monitoring   prometheusrule.monitoring.coreos.com/thanos-query              18h

Closes #790 partially

For now, we store the type of the generated resource.
@metalmatze metalmatze changed the base branch from main to validation-webhook July 8, 2023 17:47
Base automatically changed from validation-webhook to main July 12, 2023 09:03
@metalmatze metalmatze merged commit ad7a417 into main Jul 21, 2023
6 checks passed
@metalmatze metalmatze deleted the kubernetes-status branch July 21, 2023 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feature] SLOs / Rules validation
1 participant