fix(slos): BoolGauge promql expr should not be multiplied by 100

pyrra-dev · Sep 3, 2024 · dccf1ac · dccf1ac
1 parent 4648b30
commit dccf1ac
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/slo/promql.go b/slo/promql.go
@@ -728,7 +728,7 @@ func (o Objective) ErrorsRange(timerange time.Duration) string {
 
 		return expr.String()
 	case BoolGauge:
-		expr, err := parser.ParseExpr(`100 * sum by (group) ((count_over_time(metric{matchers="total"}[1s]) - sum_over_time(metric{matchers="total"}[1s]))) / sum by(group) (count_over_time(metric{matchers="total"}[1s]))`)
+		expr, err := parser.ParseExpr(`sum by (group) ((count_over_time(metric{matchers="total"}[1s]) - sum_over_time(metric{matchers="total"}[1s]))) / sum by(group) (count_over_time(metric{matchers="total"}[1s]))`)
 		if err != nil {
 			return err.Error()
 		}

diff --git a/slo/promql_test.go b/slo/promql_test.go
@@ -886,12 +886,12 @@ func TestObjective_ErrorsRange(t *testing.T) {
 	}, {
 		name:      "up-targets",
 		objective: objectiveUpTargets(),
-		expected:  `100 * sum((count_over_time(up[2h]) - sum_over_time(up[2h]))) / sum(count_over_time(up[2h]))`,
+		expected:  `sum((count_over_time(up[2h]) - sum_over_time(up[2h]))) / sum(count_over_time(up[2h]))`,
 		timerange: 2 * time.Hour,
 	}, {
 		name:      "up-targets-grouping-index",
 		objective: objectiveUpTargetsGroupingRegex(),
-		expected:  `100 * sum((count_over_time(up{instance!~"(127.0.0.1|localhost).*"}[2h]) - sum_over_time(up{instance!~"(127.0.0.1|localhost).*"}[2h]))) / sum(count_over_time(up{instance!~"(127.0.0.1|localhost).*"}[2h]))`,
+		expected:  `sum((count_over_time(up{instance!~"(127.0.0.1|localhost).*"}[2h]) - sum_over_time(up{instance!~"(127.0.0.1|localhost).*"}[2h]))) / sum(count_over_time(up{instance!~"(127.0.0.1|localhost).*"}[2h]))`,
 		timerange: 2 * time.Hour,
 	}}