Skip to content

Expose configMapMode CLI flag #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lukasjarosch wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Expose configMapMode CLI flag #23

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion charts/pyrra/Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ type: application
# to the chart and its templates, including the app version.
# Versions are expected to follow Semantic Versioning (https://semver.org/)

version: 0.15.0
version: 0.15.1

# This is the version number of the application being deployed. This version number should be
# incremented each time you make changes to the application. Versions are not expected to
Expand Down
1 change: 1 addition & 0 deletions charts/pyrra/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ The dashboards can be deployed using a ConfigMap and get's automatically [reload
| Key | Type | Default | Description |
|-----|------|---------|-------------|
| additionalLabels | object | `{}` | |
| configMapMode.enabled | bool | `false` | enables configMap mode to generate the PrometheusRules in a configMap |
| dashboards.annotations | object | `{}` | |
| dashboards.enabled | bool | `false` | enables Grafana dashboards being deployed via configmap |
| dashboards.extraLabels | object | `{}` | |
Expand Down
13 changes: 13 additions & 0 deletions charts/pyrra/templates/clusterrole.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,3 +44,16 @@ rules:
- get
- patch
- update
{{- if .Values.configMapMode.enabled }}
- apiGroups:
- ""
resources:
- configmaps
verbs:
- get
- create
- list
- watch
- update
- delete
{{- end }}
3 changes: 3 additions & 0 deletions charts/pyrra/templates/deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,9 @@ spec:
{{- if .Values.genericRules.enabled }}
- --generic-rules
{{- end }}
{{- if .Values.configMapMode.enabled }}
- --config-map-mode
{{- end }}
{{- if and .Values.validatingWebhookConfiguration.enabled ($.Capabilities.APIVersions.Has "cert-manager.io/v1") }}
- --disable-webhooks=false
{{- end }}
Expand Down
4 changes: 4 additions & 0 deletions charts/pyrra/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,6 +140,10 @@ genericRules:
# -- enables generate Pyrra generic recording rules. Pyrra generates metrics with the same name for each SLO.
enabled: false

configMapMode:
# -- enables configMap mode to generate the PrometheusRules in a configMap
enabled: false

validatingWebhookConfiguration:
# -- enables admission webhook for server to validate SLOs, this requires cert-manager to be installed
enabled: false
Expand Down