Skip to content

Build with --only-binary :all: #18058

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 5, 2025
Merged

Build with --only-binary :all: #18058

merged 2 commits into from
May 5, 2025

Conversation

di
Copy link
Member

@di di commented Apr 30, 2025

Draft release until this is merge-able.

Currently this is blocked because the following dependencies must be built from source for the following reasons:

main dependencies:

@di di force-pushed the use-only-binary-all branch from 35bc007 to fc6fe5d Compare May 2, 2025 18:36
@di di marked this pull request as ready for review May 2, 2025 19:15
@di di requested a review from a team as a code owner May 2, 2025 19:15
@di di removed the blocked Issues we can't or shouldn't get to yet label May 2, 2025
Copy link
Member

@miketheman miketheman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like it works for now.

I'm only mildly concerned that this may hamper future updates, but we can tackle that if it happens.

@di
Copy link
Member Author

di commented May 5, 2025

I think this will definitely slow down the rate at which we can upgrade to new Python versions, but the dependencies we've already adopted generally shouldn't regress here.

@di di merged commit 8540e47 into pypi:main May 5, 2025
20 checks passed
@di di deleted the use-only-binary-all branch May 5, 2025 14:41
@ewdurbin
Copy link
Member

ewdurbin commented May 5, 2025

I think this will definitely slow down the rate at which we can upgrade to new Python versions, but the dependencies we've already adopted generally shouldn't regress here.

noooooooooo :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants