Use factory.Sequence with faker.unique to remove the chance of duplicate values
#17740
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace faker providers known to occasionally fail with the unique faker (safe_email, user_name, ipv4_private Based on: FactoryBoy/factory_boy#305 See also: FactoryBoy/factory_boy#820 closes pypi#17734 relates to pypi#15398
|
Of the 4 randomly seeds from #15398 that failed for me, this change seems to fix 3 of them.
This one still fails:
|
miketheman
reviewed
Mar 10, 2025
cofiem
changed the title
factory.Sequence with faker.unique to remove the chance of duplicate values
cofiem
changed the title
factory.Sequence with faker.unique to remove the chance of duplicate valuesfactory.Sequence with faker.unique to remove the chance of duplicate values
di
approved these changes
Mar 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace faker providers known to occasionally fail with the unique faker (safe_email, user_name, ipv4_private
Based on: FactoryBoy/factory_boy#305
See also: FactoryBoy/factory_boy#820
closes #17734
relates to #15398