Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proper Error raise in Reauthentication Form #17681

Open
wants to merge 24 commits into
base: main
Choose a base branch
from

Conversation

Daksh2000
Copy link
Contributor

@Daksh2000 Daksh2000 commented Feb 28, 2025

Fixes: #16460

For proper error in password field while reauthenticating, I made some changes in reauthenticate function, adding a renderer
and returning HTTP status code 303 only in case if all form fields validation are successful , otherwise re render the form with appropriate error.

@Daksh2000 Daksh2000 requested a review from a team as a code owner February 28, 2025 18:58
@Daksh2000
Copy link
Contributor Author

Issue: #16460 (comment)

For proper error in password field while reauthenticating, I made some changes in reauthenticate function, adding a renderer and returning HTTP status code 303 only in case if all form fields validation are successful , otherwise re render the form with appropriate error.

Hi @di , Please share your views.

@Daksh2000
Copy link
Contributor Author

Issue: #16460 (comment)
For proper error in password field while reauthenticating, I made some changes in reauthenticate function, adding a renderer and returning HTTP status code 303 only in case if all form fields validation are successful , otherwise re render the form with appropriate error.

Hi @di , Please share your views.

Hi Team, could someone review this change

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No error when password is incorrect when re-authenticating.
3 participants