-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
add support for RustPython under posix #3010
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
gaborbernat
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests?
Adds support for creating virtual environment using RustPython interpreter: https://github.com/RustPython/RustPython
I have added some tests: |
gaborbernat
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests?
I have added some tests: #3010 (changes)
This is not sufficient, you'll need to do what we do for PyPy and add it to the CI as a matrix, fix the errors and then would be ready.
I'm trying to wrap my head around how the virtualenv CI tests work. As far as I understand, the python version under test is installed with actions/setup-python GitHub action. Then it's picked up by In order to add RustPython to the matrix, I see two options:
Is my understanding correct? |
|
Yes |
1 similar comment
|
Yes |
Adds support for creating virtual environment using RustPython interpreter:
https://github.com/RustPython/RustPython
Without this 'custom' RustPython creator
virtualenvfails, when specifying rustpython binary with--pythonargument. For example:tox -e fix)docs/changelogfolder