Fixes inconsistencies in pyproject.toml documentation. #197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Specifying Valid options are: or |
|
True, somehow I missed this. Thanks for taking the time and reporting this! I'll update the MR, even though there does not seem to be much interest in merging this. |
thomasbbrunner
changed the title
|
@di sorry for pinging, but is there any interest in merging this from pypa's side? |
|
(Looks like we have some unrelated test failures here that need to be resolved first) |
Merged
VladimirFokow
added a commit
to VladimirFokow/sampleproject
that referenced
this pull request
Feb 3, 2024
add the changes authored by thomasbbrunner in pypa#197
di
added a commit
that referenced
this pull request
Feb 29, 2024
* Update pyproject.toml - extend descriptions of build-system table - add useful links - edit other comments * Update pyproject.toml - be more clear that the values in [build-system] may be generated by the command line interface of the build backend, so the [build-system] table is not required - reorganize comments to better correspond to their sections * add changes from #197 add the changes authored by thomasbbrunner in #197 * implement changes from code review - separate links to guide and specification - remove text that can already be found by following the provided links - more accurate comment about the `build-backend` key * minor: ":" * better comment about extras Co-authored-by: chrysle <[email protected]> * remove # Optional coments, because instead of them we'll mark the REQUIRED fields --------- Co-authored-by: chrysle <[email protected]> Co-authored-by: Dustin Ingram <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses inconsistencies of the documentation of fields in the pyproject.toml file.
Related to #196.