Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix /changelog/ and /contributing/ docs URLs #1541

Merged
merged 2 commits into from
Sep 11, 2024
Merged

Fix /changelog/ and /contributing/ docs URLs #1541

merged 2 commits into from
Sep 11, 2024

Conversation

br3ndonland
Copy link
Contributor

@br3ndonland br3ndonland commented Sep 7, 2024

  • I have added a news fragment under changelog.d/ (if the patch affects the end users)

Summary of changes

Closes #1540

PR #1474 moved the docs to the docs/ directory, and also changed casing of some filenames.

  • docs/changelog.md -> docs/CHANGELOG.md
  • docs/contributing.md -> docs/CONTRIBUTING.md

This changed URL path parameters as well. URL paths to these pages must now be uppercased when accessing the deployed docs.

How to reproduce

For example, navigating to https://pipx.pypa.io/stable/CONTRIBUTING/ shows the correct page.

pypa-pipx-changelog-uppercase

But navigating to https://pipx.pypa.io/stable/contributing/ displays a (poorly styled) 404 page:

pypa-pipx-changelog-lowercase

This PR will move the pages back to docs/changelog.md and docs/contributing.md to restore the previous URLs to these pages.

Note that the casing changes do not affect the homepage because MkDocs automatically handles README.md as index.md.

Test plan

Tested by running

mkdocs build --clean

PR #1474 moved the docs to the `docs/` directory, and also changed
casing of some filenames.

- `docs/changelog.md` -> `docs/CHANGELOG.md`
- `docs/contributing.md` -> `docs/CONTRIBUTING.md`

This changed URL path parameters as well. URL paths to these pages must
now be uppercased when accessing the deployed docs (#1540).

For example, navigating to https://pipx.pypa.io/stable/CONTRIBUTING/
shows the correct page, but navigating to
https://pipx.pypa.io/stable/contributing/ displays a (poorly styled)
`404` page.

This commit will move the pages back to `docs/changelog.md` and
`docs/contributing.md` to restore the previous URLs to these pages.

Note that the casing changes to not affect the homepage because MkDocs
automatically handles `README.md` as `index.md`.
https://www.mkdocs.org/user-guide/writing-your-docs/#index-pages
@chrysle
Copy link
Contributor

chrysle commented Sep 9, 2024

Thanks; this'll be a doc news fragment.

@br3ndonland
Copy link
Contributor Author

Thanks; this'll be a doc news fragment.

Makes sense. Re-categorized as doc.

Copy link
Contributor

@Gitznik Gitznik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this contribution 👍

@chrysle chrysle merged commit 1b6ab14 into pypa:main Sep 11, 2024
11 checks passed
@br3ndonland br3ndonland deleted the fix-docs-urls branch September 11, 2024 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix /changelog/ and /contributing/ docs URLs
3 participants