Iussue #1460

[NerusSkyhigh]

• I have added a news fragment under changelog.d/ (if the patch affects the end users)

Summary of changes

Changed commands/common.pyline 352 from output.append(" These apps are now globally available") to output.append(" These apps are now available") as suggested on Iussue 1460.

Test plan

Tested by running

conda create --name pipx-test python pip
conda activate pipx-test
python -m pip install -e .
python -m pip install --user nox
nox -s tests-3.12

[Gitznik]

Thanks for this contribution.

I personally am in favor or adding the globally in the output, if the --global flag was passed, and dropping it if it was not.

[NerusSkyhigh]

Hi,
I feel like this issue is solved but is not getting accepted or rejected. Is there something I can do to improve it or speed up the reviewing project?
Thanks in advance for any indication.

[huxuan]

Is there something I can do to improve it or speed up the reviewing project?

As @Gitznik mentioned, we should still keep globally when --global is passed.

[NerusSkyhigh]

Hi,
sorry for the late answer but I wasn't aware of the package argparse and it took me a while to understand how arguments are parsed.
Anyway, I don't think there is an easy way to do it. The corresponding function has signature

    python_version: str,
    python_is_standalone: bool,
    package_version: str,
    package_name: str,
    new_install: bool,
    exposed_binary_names: List[str],
    unavailable_binary_names: List[str],
    exposed_man_pages: List[str],
    unavailable_man_pages: List[str],
    injected_packages: Optional[Dict[str, PackageInfo]] = None,
    suffix: str = "",
)```
and, as far as i know, none of these contains any reference to `argparse` to check wheter the option "--global" was passed.
I think there are two possible paths:
1. Rewrite the signature of the function, with a default value and backtrace its call up to a parent function where `argparse` is available
2. Ignore all possible guidelines and just do something like

for arg in sys.argv:
if "arg" == "--global":
# print one string
else:
# print the other

but I'm not a big fan of this solution.

[Gitznik]

I think there are two possible paths:

1. Rewrite the signature of the function, with a default value and backtrace its call up to a parent function where argparse is available
2. Ignore all possible guidelines and just do something like

Definitely option 1. Somewhere up the call stack it must be known whether the install is global, so you should be able to pass that right through. There should be no need for you to interact with argparse directly.