Correct the options of update command #3462
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I am wrong. Close this PR now. |
jxltom
reviewed
Jan 19, 2019
| @@ -454,7 +454,7 @@ def check( | |||
| "--outdated", is_flag=True, default=False, help=u"List out-of-date dependencies." | |||
| ) | |||
| @option("--dry-run", is_flag=True, default=None, help=u"List out-of-date dependencies.") | |||
| @install_options | |||
| @sync_options | |||
There was a problem hiding this comment.
The package is passed to state.installstate.packages by package_arg, and being used by
Line 482 in 50dcaca
sync_options
There was a problem hiding this comment.
@jxltom, that was a mistake. However, state.installstate.packages are not used after this point.
There was a problem hiding this comment.
Oh it is closed. Forget about why I said. :p
There was a problem hiding this comment.
@frostming That's true. We should support it actually. 😄
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3461
Correct the options of
updatecommand to reduce confusion.