Update DEFAULT_CROSS_BUILD_ENV_METADATA_URL to JSON file from GitHub Pages site#206
Merged
agriyakhetarpal merged 2 commits intomainfrom May 20, 2025
Merged
Conversation
1 task
ryanking13
approved these changes
May 20, 2025
Member
There was a problem hiding this comment.
Thanks!
I would like to propose that we create a new 0.30.4 release after this PR. I can do it of course, but I'd like to receive reviews on this, i.e., if this URL seems fine to you, or if I should go back to the Pyodide repo and change it to something else. Thank you! :)
Sounds good for my side.
Member
Author
|
Thank you for the review! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is related to #203, pyodide/pyodide#5642, and pypa/cibuildwheel#2002; it updates the
DEFAULT_CROSS_BUILD_ENV_METADATA_URLto use the JSON file from the GitHub Pages site set up just now, rather than the raw GitHub URL. This is being done in order to circumvent rate limits provisioned by the GitHub API. The next step after this, in a follow-up, would be to cache this even further, so that we don't access the URL repeatedly.I would like to propose that we create a new 0.30.4 release after this PR. I can do it of course, but I'd like to receive reviews on this, i.e., if this URL seems fine to you, or if I should go back to the Pyodide repo and change it to something else. Thank you! :)
cc: @joerick