Canonicalize subtensor negative integer indices #1541
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ricardoV94
force-pushed
the
canonicalize_negative_indices
branch
from
5516080 to
956b9e2
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1541 +/- ##
==========================================
+ Coverage 81.86% 81.91% +0.05%
==========================================
Files 230 230
Lines 52508 52529 +21
Branches 9339 9345 +6
==========================================
+ Hits 42984 43029 +45
+ Misses 7092 7070 -22
+ Partials 2432 2430 -2
🚀 New features to boost your workflow:
|
jessegrabowski
approved these changes
Jul 15, 2025
| for i, (dim_length, idx) in enumerate(zip(x.type.shape, idxs)): | ||
| if ( | ||
| dim_length is None | ||
| or isinstance(idx, slice) |
There was a problem hiding this comment.
We could also canonicalize negative slices if they're static, is that out of scope here?
There was a problem hiding this comment.
Yes. Slices touch on the whole subtensor_merge monster and I don't want to touch it for now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📚 Documentation preview 📚: https://pytensor--1541.org.readthedocs.build/en/1541/