Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for observed variables in the trace as well as the model #7641

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

zaxtax
Copy link
Contributor

@zaxtax zaxtax commented Jan 12, 2025

Description

This introduces the enhancement discussed in #7225

This makes it easier to use sample_posterior_predictive in model factory workflows

Checklist

Type of change

  • New feature / enhancement
  • Bug fix
  • Documentation
  • Maintenance
  • Other (please specify):

📚 Documentation preview 📚: https://pymc--7641.org.readthedocs.build/en/7641/

@zaxtax zaxtax requested a review from ricardoV94 January 12, 2025 16:38
@zaxtax zaxtax force-pushed the pull_observes_from_idata_in_pps branch from ca7c8f8 to 567fb2a Compare January 12, 2025 16:47
Copy link

codecov bot commented Jan 12, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.82%. Comparing base (671d704) to head (f24a55c).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #7641      +/-   ##
==========================================
+ Coverage   87.41%   92.82%   +5.41%     
==========================================
  Files         107      107              
  Lines       18168    18172       +4     
==========================================
+ Hits        15881    16868     +987     
+ Misses       2287     1304     -983     
Files with missing lines Coverage Δ
pymc/sampling/forward.py 96.21% <100.00%> (+0.06%) ⬆️

... and 10 files with indirect coverage changes

@zaxtax zaxtax force-pushed the pull_observes_from_idata_in_pps branch from 567fb2a to 662595b Compare January 12, 2025 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant