Skip to content

Add automatic handling for PylonItems #363

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Add automatic handling for PylonItems #363

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions pylon-core/src/main/kotlin/io/github/pylonmc/pylon/core/i18n/PylonTranslator.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ import io.github.pylonmc.pylon.core.event.PylonRegisterEvent
import io.github.pylonmc.pylon.core.event.PylonUnregisterEvent
import io.github.pylonmc.pylon.core.i18n.PylonTranslator.Companion.translator
import io.github.pylonmc.pylon.core.i18n.wrapping.LineWrapEncoder
import io.github.pylonmc.pylon.core.item.PylonItem
import io.github.pylonmc.pylon.core.item.builder.customMiniMessage
import io.github.pylonmc.pylon.core.nms.NmsAccessor
import io.github.pylonmc.pylon.core.registry.PylonRegistry
Expand Down Expand Up @@ -176,9 +177,11 @@ class PylonTranslator private constructor(private val addon: PylonAddon) : Trans
@JvmName("translateItem")
@Suppress("UnstableApiUsage")
fun ItemStack.translate(locale: Locale, arguments: List<PylonArgument> = emptyList()) {
val item = PylonItem.fromStack(this)
val usedArguments = item?.getPlaceholders() ?: arguments

editData(DataComponentTypes.ITEM_NAME) {
val translated = GlobalTranslator.render(it.withArguments(arguments), locale)
val translated = GlobalTranslator.render(it.withArguments(usedArguments), locale)
if (translated is TranslatableComponent && translated.fallback() != null) {
Component.text(translated.fallback()!!)
} else {
Expand All @@ -187,7 +190,7 @@ class PylonTranslator private constructor(private val addon: PylonAddon) : Trans
}
editData(DataComponentTypes.LORE) { lore ->
val newLore = lore.lines().flatMap { line ->
val translated = GlobalTranslator.render(line.withArguments(arguments), locale)
val translated = GlobalTranslator.render(line.withArguments(usedArguments), locale)
val encoded = LineWrapEncoder.encode(translated)
val wrapped = encoded.copy(
lines = encoded.lines.flatMap { wrapText(it, PylonConfig.translationWrapLimit) }
Expand Down
Loading