Skip to content

Data driven research #344

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 17 commits into
base: master
Choose a base branch
from
Open

Data driven research #344

wants to merge 17 commits into from

Conversation

Intybyte
Copy link
Contributor

@Intybyte Intybyte commented Sep 27, 2025 •
edited
Loading

@Seggan Seggan linked an issue Sep 29, 2025 that may be closed by this pull request
Make researches data-driven #137
Open
Seggan
Seggan requested changes Sep 29, 2025
View reviewed changes
Copy link
Member

@Seggan Seggan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As far as I understand this requires each research to be in its own file? Why split them up like that?

OhmV-IR
OhmV-IR requested changes Sep 29, 2025
View reviewed changes
@Intybyte
Copy link
Contributor Author

As far as I understand this requires each research to be in its own file? Why split them up like that?

Why not? this is same approach as item settings basically

@Seggan
Copy link
Member

Seggan commented Sep 29, 2025

Item settings are of variable length and end up being separate files, while researches are small and of a known schema. Something like recipes.

@Intybyte
Copy link
Contributor Author

Intybyte commented Sep 29, 2025 •
edited
Loading

Item settings are of variable length and end up being separate files, while researches are small and of a known schema. Something like recipes.

please don't make me rewrite everything

@Seggan
Copy link
Member

Seggan commented Sep 29, 2025

Nah it won't be everything just copy the recipe code lol

@Intybyte
Change format
c9c3eef
@Intybyte
Merge branch 'master' into feature/data-driven-researches
9b9da1b 
# Conflicts:
#	pylon-core/src/main/kotlin/io/github/pylonmc/pylon/core/util/PylonUtils.kt
@Intybyte
Optimize PylonUtils.kt import
c94c317
@LordIdra
Copy link
Contributor

LordIdra commented Oct 3, 2025

I do agree it should be one file

@JustAHuman-xD
Copy link
Contributor

(I do too)

LordIdra
LordIdra requested changes Oct 3, 2025
View reviewed changes
OhmV-IR
OhmV-IR approved these changes Oct 5, 2025
View reviewed changes
Copy link
Contributor

@OhmV-IR OhmV-IR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm cw & ig

Seggan
Seggan requested changes Oct 7, 2025
View reviewed changes
Seggan
Seggan requested changes Oct 8, 2025
View reviewed changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LordIdra LordIdra LordIdra requested changes

@Seggan Seggan Seggan approved these changes

@OhmV-IR OhmV-IR OhmV-IR approved these changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make researches data-driven
5 participants
@Intybyte @Seggan @LordIdra @JustAHuman-xD @OhmV-IR