-
Couldn't load subscription status.
- Fork 5
[ref:update-item-builders] Equipment Update #261
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
04acc4e to
dd89da4
Compare
|
This still a thing after closing the Core PR |
|
yes, im working on updating it lol |
|
theres a new core PR incoming |
543b384 to
3cbbee0
Compare
3cbbee0 to
730ca2b
Compare
Base automatically changed from
use-vanilla-entities-in-pylon-entity-block-holder
to
master
October 4, 2025 16:43
OhmV-IR
approved these changes
Oct 5, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm cw & ig
Co-authored-by: Adrien Bourdeaux <[email protected]>
Seggan
approved these changes
Oct 5, 2025
LordIdra
approved these changes
Oct 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relies on #268 (the relevant core pr changed item stack stuff so this ones core pr had to be based off of that ones)
Adds missing values & fixes some values for different equipment items while switching to using the new methods from PylonItemStackBuilder
see pylonmc/pylon-core#352
Fixes #260