pylint equivalent to pylint .
#9072
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #9072 +/- ##
==========================================
+ Coverage 95.57% 95.77% +0.20%
==========================================
Files 178 173 -5
Lines 18869 18669 -200
==========================================
- Hits 18034 17881 -153
+ Misses 835 788 -47
🚀 New features to boost your workflow:
|
|
Hmm, we might want to have it in a beta for a somewhat longish time, this feel incompatible with releasing in a week. On one hand the change is not supposed to be complex, on the other hand it actually is complex. Because the option parsing and configuration parsing is very complex (there's no explicit positional argument like you would expect with argparse, we're just implicitly relying on the first args being the fileçor_module if we don't have the stdin option -- maybe other condition apply). |
This comment has been minimized.
This comment has been minimized.
| sys.exit(code) | ||
| return | ||
|
|
||
| # Display help if there are no files to lint or no checks enabled |
There was a problem hiding this comment.
May as well clean up this comment, as we're not displaying help (right?)
| def test_no_crash_with_formatting_regex_defaults(self) -> None: | ||
| path = join(HERE, "regrtest_data", "empty.py") | ||
| self._runtest( | ||
| ["--ignore-patterns=a"], reporter=TextReporter(StringIO()), code=32 |
There was a problem hiding this comment.
What was making the prior code emit 32?
| ``pylint`` is now equivalent to ``pylint .`` and won't show the help by default anymore. | ||
| The help is still available with ``pylint --help`` or ``pylint --long-help``. |
There was a problem hiding this comment.
Let's not promise equivalence with pylint .. I'm showing a behavior difference. Before, cd to a directory you haven't installed with pip, invoke pylint ., you get a quick lint of the __init__.py only; now you get the whole package linted.
|
I'm thinking more and more that we should base it on https://github.com/pylint-dev/pylint/pull/7496/files so we can just add a default value for |
I would be very much in favour of that, but need some direction in moving that PR forward. |
|
Let's move that change to 4.0.0 and try to add the |
Pierre-Sassoulas
added
Breaking changes for 4.0 🦤
and removed
Breaking changes for 3.0 🦤
labels
```
def parse_known_args(self, args=None, namespace=None):
if args is None:
# args default to the system args
args = _sys.argv[1:]
else:
# make sure that args are mutable
args = list(args)
```
Pierre-Sassoulas
force-pushed
the
pylint-default-to-current-dir
branch
from
2955bee to
b2b0571
Compare
|
🤖 According to the primer, this change has no effect on the checked open source code. 🤖🎉 This comment was generated for commit b2b0571 |
Pierre-Sassoulas
added
Breaking changes 🦤
and removed
Breaking changes for 4.0 🦤
labels
3 participants
Type of Changes
Description
pylintis now equivalent topylint .and won't show the help by default anymore.The help is still available with
pylint --helporpylint --long-help.Closes #5701