Skip to content

Initial fixes for Python 3.14 #2747

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 16, 2025
Merged

Conversation

cdce8p
Copy link
Member

@cdce8p cdce8p commented May 15, 2025

Tested against 3.14.0b1 locally. We might still need to adjust some things as more pre-release versions come out but this provides a good starting point in combination with #2731.

Relevant changes for Python 3.14

@cdce8p cdce8p added Maintenance Discussion or action around maintaining astroid or the dev workflow python 3.14 labels May 15, 2025
@cdce8p cdce8p requested a review from Pierre-Sassoulas May 15, 2025 22:51
Copy link

codecov bot commented May 15, 2025

Codecov Report

Attention: Patch coverage is 88.88889% with 1 line in your changes missing coverage. Please review.

Project coverage is 93.23%. Comparing base (3636bc2) to head (d52f79d).
Report is 7 commits behind head on main.

Files with missing lines Patch % Lines
astroid/brain/brain_typing.py 80.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2747      +/-   ##
==========================================
+ Coverage   93.21%   93.23%   +0.02%     
==========================================
  Files          93       93              
  Lines       11072    11078       +6     
==========================================
+ Hits        10321    10329       +8     
+ Misses        751      749       -2     
Flag Coverage Δ
linux 93.10% <88.88%> (+0.02%) ⬆️
pypy 93.23% <88.88%> (+0.02%) ⬆️
windows 93.22% <88.88%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
astroid/brain/brain_pathlib.py 92.00% <100.00%> (ø)
astroid/const.py 100.00% <100.00%> (ø)
astroid/brain/brain_typing.py 87.11% <80.00%> (-0.39%) ⬇️

... and 5 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@cdce8p cdce8p removed the request for review from Pierre-Sassoulas May 16, 2025 14:52
@cdce8p cdce8p merged commit 43111bb into pylint-dev:main May 16, 2025
21 of 22 checks passed
@cdce8p cdce8p deleted the fix-brain-3.14 branch May 16, 2025 14:53
@cdce8p cdce8p added this to the 4.0.0 milestone May 16, 2025
Copy link
Contributor

The backport to maintenance/3.3.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-maintenance/3.3.x maintenance/3.3.x
# Navigate to the new working tree
cd .worktrees/backport-maintenance/3.3.x
# Create a new branch
git switch --create backport-2747-to-maintenance/3.3.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 43111bb4e2b8ae618168a449dcabcd40d19e5c3a
# Push it to GitHub
git push --set-upstream origin backport-2747-to-maintenance/3.3.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-maintenance/3.3.x

Then, create a pull request where the base branch is maintenance/3.3.x and the compare/head branch is backport-2747-to-maintenance/3.3.x.

@Pierre-Sassoulas Pierre-Sassoulas modified the milestones: 4.0.0, 3.3.11 May 17, 2025
cdce8p added a commit to cdce8p/astroid that referenced this pull request May 17, 2025
cdce8p added a commit that referenced this pull request May 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport maintenance/3.3.x Maintenance Discussion or action around maintaining astroid or the dev workflow python 3.14
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants