-
-
Notifications
You must be signed in to change notification settings - Fork 292
Initial fixes for Python 3.14 #2747
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2747 +/- ##
==========================================
+ Coverage 93.21% 93.23% +0.02%
==========================================
Files 93 93
Lines 11072 11078 +6
==========================================
+ Hits 10321 10329 +8
+ Misses 751 749 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-maintenance/3.3.x maintenance/3.3.x
# Navigate to the new working tree
cd .worktrees/backport-maintenance/3.3.x
# Create a new branch
git switch --create backport-2747-to-maintenance/3.3.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 43111bb4e2b8ae618168a449dcabcd40d19e5c3a
# Push it to GitHub
git push --set-upstream origin backport-2747-to-maintenance/3.3.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-maintenance/3.3.x Then, create a pull request where the |
(cherry picked from commit 43111bb)
Tested against
3.14.0b1
locally. We might still need to adjust some things as more pre-release versions come out but this provides a good starting point in combination with #2731.Relevant changes for Python 3.14
typing.ByteString
andcollections.abc.ByteString
were removedhttps://docs.python.org/3.13/library/typing.html#typing.ByteString
parents
changed back topathlib._PathParents
typing.Union
was implemented in C andtypes.UnionType
is now an alias fortyping.Union
gh-105499: Merge typing.Union and types.UnionType python/cpython#105511
In theory we could think about renaming the
UnionType
class or at least think about if we want to change thepytype
attributeastroid/astroid/bases.py
Lines 738 to 742 in 5937f3d
astroid/astroid/bases.py
Lines 761 to 762 in 5937f3d