Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add with_model_from_memory_directly for .ort files #72

Merged
merged 2 commits into from
Aug 27, 2023
Merged

Add with_model_from_memory_directly for .ort files #72

merged 2 commits into from
Aug 27, 2023

Conversation

SunDoge
Copy link
Contributor

@SunDoge SunDoge commented Aug 1, 2023

Fix #71 .

  • Add with_model_from_memory_directly for .ort files.
  • Change with_model_from_memory output type to make it consistent with with_model_from_file.

@alexpusch
Copy link

+1 for making with_model_from_memory return Session. Lifetime in InMemorySession raises difficulties with borrow checker

@decahedron1 decahedron1 mentioned this pull request Aug 16, 2023
Merged
8 tasks
@decahedron1 decahedron1 merged commit ba9df19 into pykeio:main Aug 27, 2023
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
No open projects
ort v2.0
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Do we really need ort::session::InMemorySession?
3 participants
@SunDoge @alexpusch @decahedron1