Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Session::run_async #174

Merged
merged 6 commits into from
Mar 21, 2024
Merged

Session::run_async #174

merged 6 commits into from
Mar 21, 2024

Conversation

decahedron1
Copy link
Member

@decahedron1 decahedron1 commented Mar 13, 2024

Natively asynchronous Session::run.

TODO

  • Check unsoundness. This code is probably very terrible. Anyone able to review? :^)
  • Make the example more functional
  • Maybe remove run_with_options_async and just always create a RunOptions that we share with the future, so it can automatically cancel when it drops.

@decahedron1 decahedron1 added help wanted Extra attention is needed perf labels Mar 13, 2024
Copy link

codecov bot commented Mar 13, 2024

Codecov Report

Attention: Patch coverage is 0% with 98 lines in your changes are missing coverage. Please review.

Project coverage is 43.20%. Comparing base (39bd0d0) to head (8ba1b73).
Report is 4 commits behind head on main.

Files Patch % Lines
src/session/async.rs 0.00% 55 Missing ⚠️
src/session/mod.rs 0.00% 43 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #174      +/-   ##
==========================================
- Coverage   46.07%   43.20%   -2.87%     
==========================================
  Files          23       24       +1     
  Lines        1476     1574      +98     
==========================================
  Hits          680      680              
- Misses        796      894      +98     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@decahedron1 decahedron1 added enhancement New feature or request and removed perf labels Mar 18, 2024
@decahedron1 decahedron1 merged commit 979a591 into main Mar 21, 2024
6 of 8 checks passed
@decahedron1 decahedron1 deleted the run-async branch October 19, 2024 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant