-
Notifications
You must be signed in to change notification settings - Fork 18
Documentation update #1885
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Documentation update #1885
Conversation
|
|
||
| pyiron (called pyron) is developed in the [Computational Materials Design department](https://www.mpie.de/CM) of | ||
| [Joerg Neugebauer](https://www.mpie.de/person/43010/2763386) at the [Max Planck Institut für Eisenforschung (Max Planck Institute for iron research)](https://www.mpie.de/2281/en). | ||
| [Joerg Neugebauer](https://www.mpie.de/person/43010/2763386) at the [Max Planck Institut für Nachhaltige Materialien (Max Planck Institute for Sustainable Materials)](https://www.mpie.de/2281/en). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The link just brings me to the mpie.de page, what was the desired target? The pyiron page https://www.mpie.de/3880353/pyiron ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking at the history of the link, it always pointed just to the English version of the institutes website:
https://web.archive.org/web/20230206064237/https://www.mpie.de/2281/en
Still I agree it might make sense to link the pyiron site of the institutes website.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1885 +/- ##
=======================================
Coverage 66.33% 66.33%
=======================================
Files 75 75
Lines 12220 12220
=======================================
Hits 8106 8106
Misses 4114 4114 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jan-janssen
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
I found some small nits on the web-page I did not expect this way.