-
Notifications
You must be signed in to change notification settings - Fork 1
Test with Python 3.14 #149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the WalkthroughBumps Python version references from 3.13 to 3.14 in the GitHub Actions CI workflow and adds the corresponding 3.14 classifier in pyproject.toml. No changes to CI step order, commands, or project dependencies. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
| python-version: '3.14' | ||
|
|
||
| - operating-system: ubuntu-latest | ||
| python-version: '3.13' | ||
| python-version: '3.14' | ||
|
|
||
| - operating-system: windows-latest | ||
| python-version: '3.14' | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Update the packaging smoke env to 3.14 as well.
The new 3.14 matrix entries still call conda create -n py313 python=3.13.2, so our install smoke test never exercises Python 3.14. Any packaging issue specific to 3.14 will slip through even though the job is labeled 3.14. Please spin up a 3.14 env (and adjust the activation name accordingly) to keep the smoke test aligned with the matrix target.
Apply this diff in the “Build Test Environment” step:
- conda create -y -n py313 python=3.13.2 conda=25.3.1 executorlib=1.6.1 hatchling=1.27.0 hatch-vcs=0.5.0
- conda activate py313
+ conda create -y -n py314 python=3.14.0 conda=25.3.1 executorlib=1.6.1 hatchling=1.27.0 hatch-vcs=0.5.0
+ conda activate py314Committable suggestion skipped: line range outside the PR's diff.
🤖 Prompt for AI Agents
.github/workflows/pipeline.yml around lines 126 to 133: the packaging smoke test
still creates and activates a Python 3.13 conda env despite the matrix entry
being 3.14; update the "Build Test Environment" step to create a conda env for
Python 3.14 (e.g., change conda create -n py313 python=3.13.2 to conda create -n
py314 python=3.14) and update any subsequent activation commands to use the new
env name (py314) so the smoke test actually runs under Python 3.14.
Summary by CodeRabbit
Chores
Documentation