Skip to content

Conversation

@jan-janssen
Copy link
Member

@jan-janssen jan-janssen commented Oct 8, 2025

Summary by CodeRabbit

  • Chores

    • Updated CI pipeline to run against Python 3.14 across all environments and test matrices.
  • Documentation

    • Updated project metadata to include the Python 3.14 classifier, reflecting compatibility in published information.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 8, 2025

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Walkthrough

Bumps Python version references from 3.13 to 3.14 in the GitHub Actions CI workflow and adds the corresponding 3.14 classifier in pyproject.toml. No changes to CI step order, commands, or project dependencies.

Changes

Cohort / File(s) Summary
CI workflow Python version bump
.github/workflows/pipeline.yml
Updated all Python 3.13 references to 3.14 across setup actions, matrix entries, and conda/miniconda configuration. No changes to job steps or control flow.
Packaging metadata update
pyproject.toml
Added classifier: "Programming Language :: Python :: 3.14". No other metadata or dependency changes.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

Poem

A whisker twitch, a version hop,
From 3.13 to 3.14 we pop.
CI burrows hum along in line,
Classifiers updated—looking fine.
I stamp my paw: “All set to run!”
Pip dreams rise with morning sun. 🐇✨

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check ✅ Passed The title "Test with Python 3.14" accurately and succinctly describes the primary change of updating the CI configuration to use Python 3.14 for testing, making it clear what the pull request accomplishes.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between fec0242 and 6d39a8f.

📒 Files selected for processing (2)
  • .github/workflows/pipeline.yml (5 hunks)
  • pyproject.toml (1 hunks)

Comment on lines +126 to +133
python-version: '3.14'

- operating-system: ubuntu-latest
python-version: '3.13'
python-version: '3.14'

- operating-system: windows-latest
python-version: '3.14'

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major

Update the packaging smoke env to 3.14 as well.

The new 3.14 matrix entries still call conda create -n py313 python=3.13.2, so our install smoke test never exercises Python 3.14. Any packaging issue specific to 3.14 will slip through even though the job is labeled 3.14. Please spin up a 3.14 env (and adjust the activation name accordingly) to keep the smoke test aligned with the matrix target.

Apply this diff in the “Build Test Environment” step:

-        conda create -y -n py313 python=3.13.2 conda=25.3.1 executorlib=1.6.1 hatchling=1.27.0 hatch-vcs=0.5.0
-        conda activate py313
+        conda create -y -n py314 python=3.14.0 conda=25.3.1 executorlib=1.6.1 hatchling=1.27.0 hatch-vcs=0.5.0
+        conda activate py314

Committable suggestion skipped: line range outside the PR's diff.

🤖 Prompt for AI Agents
.github/workflows/pipeline.yml around lines 126 to 133: the packaging smoke test
still creates and activates a Python 3.13 conda env despite the matrix entry
being 3.14; update the "Build Test Environment" step to create a conda env for
Python 3.14 (e.g., change conda create -n py313 python=3.13.2 to conda create -n
py314 python=3.14) and update any subsequent activation commands to use the new
env name (py314) so the smoke test actually runs under Python 3.14.

@jan-janssen jan-janssen marked this pull request as draft October 8, 2025 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants