Skip to content

Conversation

@jan-janssen
Copy link
Member

@jan-janssen jan-janssen commented Jan 25, 2026

Summary by CodeRabbit

  • Chores
    • Updated SciPy dependency version to 1.17.0 across all environments and configuration files.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 25, 2026

📝 Walkthrough

Walkthrough

This pull request updates the SciPy dependency version from 1.16.3 to 1.17.0 across four configuration files used for continuous integration, Binder environments, and package installation specifications.

Changes

Cohort / File(s) Change Summary
SciPy Version Bump
.ci_support/environment-docs.yml, .ci_support/environment.yml, binder/environment.yml, pyproject.toml
Updates SciPy from 1.16.3 to 1.17.0 across all environment and dependency configuration files

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

Suggested labels

dependencies

Poem

🐰 A hop, a skip, through version land,
SciPy's bumped by my swift hand,
From 1.16.3 to 1.17.0 we bound,
Consistent updates all around! ✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'Update scipy to 1.17.0' clearly and directly describes the main change across all modified files, which are consistent scipy version updates from 1.16.3 to 1.17.0 in environment and dependency configuration files.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@jan-janssen
Copy link
Member Author

Wait for pyiron/structuretoolkit#449

@jan-janssen jan-janssen marked this pull request as draft January 25, 2026 16:20
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Fix all issues with AI agents
In `@pyproject.toml`:
- Around line 27-32: The pyproject dependency pin "scipy==1.17.0" in the
dependencies list is incompatible with the declared Python support (3.9–3.10);
either change the project metadata python_requires to require Python >=3.11
(update python_requires in pyproject.toml) or downgrade the SciPy pin to a
release that supports 3.9/3.10 (e.g., replace "scipy==1.17.0" with a
1.10.x/1.9.x version) so the "dependencies" list and python_requires are
consistent.

Comment on lines 27 to 32
dependencies = [
"ase==3.27.0",
"numpy==2.3.5",
"scipy==1.16.3",
"scipy==1.17.0",
"spglib==2.7.0",
]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🔴 Critical

🧩 Analysis chain

🌐 Web query:

scipy 1.17.0 PyPI release supported python versions

💡 Result:

SciPy 1.17.0 on PyPI supports Python 3.11, 3.12, 3.13, and 3.14 (PyPI metadata: Requires-Python: >=3.11; classifiers list 3.11–3.14; wheels are published for cp311–cp314). [1]


🌐 Web query:

scipy 1.17.0 numpy compatibility requirements

💡 Result:

SciPy 1.17.0 requires NumPy 1.26.4 or newer (i.e., numpy>=1.26.4). [1][2]


SciPy 1.17.0 requires Python ≥3.11, incompatible with declared Python 3.9–3.10 support.

SciPy 1.17.0 drops support for Python 3.9 and 3.10 (requires Python ≥3.11). The project claims to support Python 3.9–3.14, making this dependency unpinnable for Python 3.9 and 3.10. Either update the minimum Python version to 3.11 in project metadata or downgrade SciPy to a version supporting Python 3.9+. NumPy 2.3.5 is compatible with SciPy 1.17.0.

🤖 Prompt for AI Agents
In `@pyproject.toml` around lines 27 - 32, The pyproject dependency pin
"scipy==1.17.0" in the dependencies list is incompatible with the declared
Python support (3.9–3.10); either change the project metadata python_requires to
require Python >=3.11 (update python_requires in pyproject.toml) or downgrade
the SciPy pin to a release that supports 3.9/3.10 (e.g., replace "scipy==1.17.0"
with a 1.10.x/1.9.x version) so the "dependencies" list and python_requires are
consistent.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants