-
Notifications
You must be signed in to change notification settings - Fork 4
Update scipy to 1.17.0 #618
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
📝 WalkthroughWalkthroughThis pull request updates the SciPy dependency version from 1.16.3 to 1.17.0 across four configuration files used for continuous integration, Binder environments, and package installation specifications. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
Suggested labels
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Wait for pyiron/structuretoolkit#449 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@pyproject.toml`:
- Around line 27-32: The pyproject dependency pin "scipy==1.17.0" in the
dependencies list is incompatible with the declared Python support (3.9–3.10);
either change the project metadata python_requires to require Python >=3.11
(update python_requires in pyproject.toml) or downgrade the SciPy pin to a
release that supports 3.9/3.10 (e.g., replace "scipy==1.17.0" with a
1.10.x/1.9.x version) so the "dependencies" list and python_requires are
consistent.
| dependencies = [ | ||
| "ase==3.27.0", | ||
| "numpy==2.3.5", | ||
| "scipy==1.16.3", | ||
| "scipy==1.17.0", | ||
| "spglib==2.7.0", | ||
| ] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧩 Analysis chain
🌐 Web query:
scipy 1.17.0 PyPI release supported python versions
💡 Result:
SciPy 1.17.0 on PyPI supports Python 3.11, 3.12, 3.13, and 3.14 (PyPI metadata: Requires-Python: >=3.11; classifiers list 3.11–3.14; wheels are published for cp311–cp314). [1]
🌐 Web query:
scipy 1.17.0 numpy compatibility requirements
💡 Result:
SciPy 1.17.0 requires NumPy 1.26.4 or newer (i.e., numpy>=1.26.4). [1][2]
SciPy 1.17.0 requires Python ≥3.11, incompatible with declared Python 3.9–3.10 support.
SciPy 1.17.0 drops support for Python 3.9 and 3.10 (requires Python ≥3.11). The project claims to support Python 3.9–3.14, making this dependency unpinnable for Python 3.9 and 3.10. Either update the minimum Python version to 3.11 in project metadata or downgrade SciPy to a version supporting Python 3.9+. NumPy 2.3.5 is compatible with SciPy 1.17.0.
🤖 Prompt for AI Agents
In `@pyproject.toml` around lines 27 - 32, The pyproject dependency pin
"scipy==1.17.0" in the dependencies list is incompatible with the declared
Python support (3.9–3.10); either change the project metadata python_requires to
require Python >=3.11 (update python_requires in pyproject.toml) or downgrade
the SciPy pin to a release that supports 3.9/3.10 (e.g., replace "scipy==1.17.0"
with a 1.10.x/1.9.x version) so the "dependencies" list and python_requires are
consistent.
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.