Skip to content

Conversation

@jan-janssen
Copy link
Member

No description provided.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 16, 2026

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

from ase.data import reference_states, atomic_numbers
import numpy as np
from ase import Atoms
from random import random
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
from random import random
import random

Atoms: The structure after MD simulation.
"""

print(f"Running NPT MD at T = {temperature} K")
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The user should have the option to enable or disable the print out, for example by setting a debug flag.

Comment on lines +225 to +229
print(
f"Both structures have {key_max} above half distribution at temperatures {temperature_left} and {temperature_right}"
)
print("Increasing temperatures...")
print("-----------------------------------------------------")
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The user should have the option to enable or disable the print out, for example by setting a debug flag.

Comment on lines +247 to +251
print(
f"Left structure has {key_max} above half distribution at temperature {temperature_left}, right structure below at temperature {temperature_right}"
)
print("Decreasing temperatures...")
print("-----------------------------------------------------")
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The user should have the option to enable or disable the print out, for example by setting a debug flag.

Comment on lines +267 to +271
print(
f"Both structures have {key_max} below half distribution at temperatures {temperature_left} and {temperature_right}"
)
print("Decreasing temperatures...")
print("-----------------------------------------------------")
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The user should have the option to enable or disable the print out, for example by setting a debug flag.

structure_left = structure_after_minimization
structure_right = _next_calc(
structure=structure_after_minimization,
print("Running at the highest temperature")
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The user should have the option to enable or disable the print out, for example by setting a debug flag.

temperature_step = temperature_right - temperature_left
return int(round(temperature_left))

print(f"Melting point estimated at T = {temperature_left} K")
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The user should have the option to enable or disable the print out, for example by setting a debug flag.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants