-
Notifications
You must be signed in to change notification settings - Fork 4
Extension of the melting workflow #612
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: melting
Are you sure you want to change the base?
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
| from ase.data import reference_states, atomic_numbers | ||
| import numpy as np | ||
| from ase import Atoms | ||
| from random import random |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| from random import random | |
| import random |
| Atoms: The structure after MD simulation. | ||
| """ | ||
|
|
||
| print(f"Running NPT MD at T = {temperature} K") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The user should have the option to enable or disable the print out, for example by setting a debug flag.
| print( | ||
| f"Both structures have {key_max} above half distribution at temperatures {temperature_left} and {temperature_right}" | ||
| ) | ||
| print("Increasing temperatures...") | ||
| print("-----------------------------------------------------") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The user should have the option to enable or disable the print out, for example by setting a debug flag.
| print( | ||
| f"Left structure has {key_max} above half distribution at temperature {temperature_left}, right structure below at temperature {temperature_right}" | ||
| ) | ||
| print("Decreasing temperatures...") | ||
| print("-----------------------------------------------------") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The user should have the option to enable or disable the print out, for example by setting a debug flag.
| print( | ||
| f"Both structures have {key_max} below half distribution at temperatures {temperature_left} and {temperature_right}" | ||
| ) | ||
| print("Decreasing temperatures...") | ||
| print("-----------------------------------------------------") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The user should have the option to enable or disable the print out, for example by setting a debug flag.
| structure_left = structure_after_minimization | ||
| structure_right = _next_calc( | ||
| structure=structure_after_minimization, | ||
| print("Running at the highest temperature") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The user should have the option to enable or disable the print out, for example by setting a debug flag.
| temperature_step = temperature_right - temperature_left | ||
| return int(round(temperature_left)) | ||
|
|
||
| print(f"Melting point estimated at T = {temperature_left} K") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The user should have the option to enable or disable the print out, for example by setting a debug flag.
No description provided.