Add support for enabling OpenRC service on a specific runlevel #1397
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
3.x
at this time)scripts/dev-test.sh
)scripts/dev-lint.sh
)Hello and thank you for your work on this project :)
I find the design to be very clear and well-thought, making it easy to engage with contributing.
I want to use pyinfra to enable a nftables service on the boot runlevel with OpenRC. I noticed that the openrc.service operation would always trigger a change on every run even though the service was never really enabled on this runlevel. This is because the change was always happening on the default runlevel, ignoring the configuration.
I would like to propose these changes:
I did not find it necessary to update the openrc.service documentation.
I also fixed a small typo in a link in the contributing documentation.