Introduce Finalizers to avoid cycles #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As per #8, there was a leak due to cycles and the definition of a `__del__` destructor. This instead uses weak proxies to be notified of deletion and invoke the correct destructor. A new type, `_BaseFinalizer` is introduced, where one can override the destruction behaviour by defining `destructor`.
Open
lazka
added a commit
that referenced
this pull request
Aug 6, 2014
Introduce Finalizers to avoid cycles
|
Sorry for the delay. Thanks for this. btw. "./setup.py quality" will run pep8/pyflakes tests from https://github.com/lazka/pgi/tree/master/tests/misc It can be a bit annoying, but it makes sure the code is tidy. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per #8, there was a leak due to cycles and the definition of a
__del__destructor. This instead uses weak proxies to be notified ofdeletion and invoke the correct destructor.
A new type,
_BaseFinalizeris introduced, where one can override thedestruction behaviour by defining
destructor.