Add warning when using negative rect dimensions in draw module

[mzivic7]

Using negative rect dimension values have some undesirable results as shown in #2727.
This PR adds deprecation warning to these draw functions: draw.rect, draw.ellipse, draw.arc when using negative value for rect width and height.
And prevents anything from being drawn at wrong position.
Warnings are also added to docs and tests.
This warning will also be added to draw.aaellipse in #3016

Sample code

import pygame
pygame.init()
screen = pygame.display.set_mode((300, 300))
clock = pygame.time.Clock()
run = True
while run:
  for event in pygame.event.get():
      if event.type == pygame.QUIT:
          run = False
  screen.fill((0, 0, 0))
  pygame.draw.rect(screen, "white", (150, 150, -50, 30), 0)
  pygame.draw.ellipse(screen, "white", (150, 150, -50, 30), 0)
  pygame.draw.arc(screen, "white", (150, 150, -50, 30), 0, 180, 0)
  pygame.display.flip()
  clock.tick(60)
pygame.quit()

[bilhox]

It seems fair to me, LGTM !

[ankith26]

while thinking about this, I realised that some other draw API also takes in rect style arguments. How are negative dims handled everywhere else. Whatever fix we do, we should try to be consistent with the approach everywhere

[mzivic7]

I added same warning, docs and tests to draw.rect and draw.arc

[ankith26]

Can you make all the 2.5.2 -> 2.5.3 in this PR?

[mzivic7]

Sure, here it comes.

[ankith26]

LGTM, thanks for the PR 🎉

[Starbuck5]

I'm not convinced this is the thing to do.

If it's a problem have the algorithm normalize the rect first?

[Starbuck5]

Did some testing,

• pygame.draw.arc: Seems to not draw if the rect dimensions are negative
• pygame.draw.ellipse: Described in original issue, but my testing TLDR is that negative rect widths are drawn, negative rect heights are not, and negative rect widths are always drawn filled for some reason.
• pygame.draw.rect: With or without outline nothing is drawn with negative dimensions
• pygame.draw.rect (rounded corners): Interestingly rects with rounded corners draw with negative dimensions fine.

I still think the most straightforward way to fix this is normalize the rect arguments when they come in. (https://pyga.me/docs/ref/rect.html#pygame.Rect.normalize)

[mzivic7]

Why is normalizing input rects bad:

• Arc can be non-symmetrical, so if its rect is normalized, should it be mirrored?
• Normalize function would have no purpose, because every rect input is normalized internally.
• One drags right side of rect over left side and get negative width, and he want to calculate area or perimeter, but it turns out to be wrong, so he then has to call normalize() to get correct area or use few abs().
• Enforced normalization would only add more cpu load, those few who needs this functionality just have to use normalize(), and probably already do.

So I will remove warning and only disable drawing if rect width/height is negative.