XSS in search highlight, filter state lost on refresh, double scan on…#109
Merged
Conversation
… project page Pro 1 — Replace innerHTML highlight injection with DOM node construction (createTextNode + createElement) to prevent XSS from log message content. Pro2 — Auto-refresh now appends new log entries to the DOM instead of calling location.reload(), so filters, search, and scroll are preserved. Full reload only when session status changes. Pro3 — Extracted _build_projects_list(sessions) so get_project() calls get_all_sessions() once instead of twice per request.
Collaborator
|
Thank you very much for your work! |
Contributor
Author
|
Hi. @blkdmr . |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… project page
Pro 1 — Replace innerHTML highlight injection with DOM node construction (createTextNode + createElement) to prevent XSS from log message content.
Pro2 — Auto-refresh now appends new log entries to the DOM instead of calling location.reload(), so filters, search, and scroll are preserved. Full reload only when session status changes.
Pro3 — Extracted _build_projects_list(sessions) so get_project() calls get_all_sessions() once instead of twice per request.