Skip to content

Fix task_context.input_tables (needed for DB2 input table locking) #144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 7, 2024
Merged

Fix task_context.input_tables (needed for DB2 input table locking) #144

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fafe97c
Fix task_context.input_tables (needed for DB2 input table locking)
nicolasmueller Feb 29, 2024
ff7becd
Fix task_context.input_tables (needed for DB2 input table locking)
nicolasmueller Feb 29, 2024
33ff02c
Merge branch 'main' into fix_db2_input_tables
nicolasmueller Mar 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions docs/source/changelog.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,8 @@
* Add support for `ExternalTableReference` to point to tables in external (i.e. not managed by `pipedag`) schemas.
* Remove support for `ExternalTableReference` that points to table in schema of current stage. I.e. `ExternalTableReference` can only point to tables in external schemas.
- Fix polars import in `pyproject.toml` when using OS X with rosetta2
- Bug fix ibm_db2 backend:
* input tables for SQL queries were not locked

## 0.6.10 (2024-02-29)
- Fix bug where a `Task` that was declared lazy but provided a `Table` without a query string would always be cache valid.
Expand Down
2 changes: 1 addition & 1 deletion src/pydiverse/pipedag/materialize/core.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -588,7 +588,7 @@ def _input_tables_visitor(x):
input_tables.append(x)
return x

deep_map(bound.arguments.values(), _input_tables_visitor)
deep_map(bound.arguments, _input_tables_visitor)
task_context.input_tables = input_tables

# Not found in cache / lazy -> Evaluate Function
Expand Down