Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(feat): Support for
pandas
ExtensionArray
#8723(feat): Support for
pandas
ExtensionArray
#8723Changes from 40 commits
b2712f1
47bddd2
dc8b788
75524c8
c9ab452
1f3d0fa
8a70e3c
f5a6505
08a4feb
d5b218b
00256fa
b7ddbd6
a165851
a826edd
fde19ea
4c55707
58ba17d
a255310
4e78b7e
d9cedf5
426664d
22ca77d
f32cfdf
60f8927
ff22d76
2153e81
b6d0b31
d285871
d847277
8238c64
1260cd4
b04ef98
b9937bf
0bba03f
b714549
a3a678c
e521844
2d3e930
04c9969
5514539
bedfa5c
e6c2690
82dbda9
12217ed
dd5b87d
761a874
52cabc8
e0d58fa
c1e0e64
17e3390
dd2ef39
c8e6bfe
b2a9517
f5e1bd0
407fad1
3a47f09
fdd3de4
6b23629
1c9047f
9be6b03
d9304f1
6ec6725
bc9ac4c
1e906db
6fb8668
8f034b4
90a6de6
2bd422a
ff67943
661d9f2
caee1c6
1d12f5e
31dfbb5
23b347f
902c74b
0b64506
0c7e023
dd7fe98
f0df768
e2f0487
1eb6741
2a7300a
9cceadc
f2588c1
a0a63bd
5bb2bde
f85f166
7ecdeba
6bc40fc
e9dc53f
4791799
c649362
fc60dcf
0374086
b9515a6
72bf807
63b6c42
1d18439
17f05da
c906c81
e6db83b
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@TomNicholas see for example here about checking explicitly, so decoupling this PR should be doable. Behavior on tests seemed the same
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@benbovy speaking of the
indexing.py
file, I noticed thePandasIndexingAdapter
returns anp.array
version of the index in certain cases so that multi-dim opertaions (such as broadcast?) can work. Should I do the same here? I explicitly don't support this functionality here (see point 1. on this comment for why I made this decision). I don't have strong feelings, but I am inclined to not support it by default, especially since withplum.dispatch
, the behavior can be overridden.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't have strong feelings either on this.