Update Variable metadata when using 'a' mode in Zarr #8159
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for opening this pull request! It may take us a few days to respond here, so thank you for being patient. |
github-actions
bot
added
topic-backends
topic-zarr
krokosik
changed the title
|
Sorry this hasn't got a review. Without being the best informed person on this — one potential issue here — if we're updating the metadata, do we risk a issue with two concurrent writers where each writer needs to read the current metadata, and the first writer can leave the files in a partially corrupted state? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
whats-new.rstapi.rstBecause the DataArray in a DataSet's data variable when saving to zarr, the incorrect metadata update behaviour applies to it. This is an attempt to fix the TODO left by PR5252. The tests are passing, but as I'm quite new to this repo, I'm not sure what cases should be tested as well. @shoyer could you share some insight please?