Skip to content

BUG clarify DataTree constructor error for mappings #11515

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
aryansk wants to merge 2 commits into
base: main
Choose a base branch
from
+9 −1
Draft

BUG clarify DataTree constructor error for mappings #11515

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f62ea30
BUG clarify DataTree constructor error
aryansk Aug 12, 2026
b37990b
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Aug 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion xarray/core/datatree.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,7 +140,9 @@ def _to_new_dataset(data: Dataset | Coordinates | None) -> Dataset:
elif data is None:
ds = Dataset()
else:
raise TypeError(f"data object is not an xarray.Dataset, dict, or None: {data}")
raise TypeError(
f"data object is not an xarray.Dataset, Coordinates, or None: {data}"
)
return ds


Expand Down
6 changes: 6 additions & 0 deletions xarray/tests/test_datatree.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -201,6 +201,12 @@ def test_create_with_data(self) -> None:
with pytest.raises(TypeError):
DataTree(name="mary", dataset="junk") # type: ignore[arg-type]

with pytest.raises(
TypeError,
match=r"data object is not an xarray.Dataset, Coordinates, or None: \{\}",
):
DataTree(name="mary", dataset={}) # type: ignore[arg-type]

def test_set_data(self) -> None:
john = DataTree(name="john")
dat = xr.Dataset({"a": 0})
Expand Down
Loading